Skip to content

get_test_tmp_dir() should return system tmp, not current dir #6964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
steven-johnson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

get_test_tmp_dir() should return system tmp, not current dir #6964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions test/common/halide_test_dirs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,18 @@ inline std::string get_test_tmp_dir() {
// If TEST_TMPDIR is specified, we assume it is a valid absolute path
std::string dir = Test::get_env_variable("TEST_TMPDIR");
if (dir.empty()) {
// If not specified, use current dir.
dir = Test::get_current_directory();
// If not specified, use system tmp.
#ifdef _WIN32
char p[MAX_PATH];
DWORD ret = GetTempPathA(MAX_PATH, p);
if (ret == 0) {
assert(false && "GetTempPathA() failed.");
return "/unlikely_path/";
}
dir = p;
#else
dir = "/tmp";
#endif
}
bool is_absolute = dir.size() >= 1 && dir[0] == '/';
char sep = '/';
Expand Down