Fix runtime vscale assertion in SVE #8876
Merged
+66
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the issue that runtime vscale assert never failed whatever vector_bits is set in Target because llvm compiler asserts llvm.vscale value at compile-time and optimize away the runtime call if the function has the attribute of vscale_range(n,m) where n==m.
zvookin
reviewed
Nov 19, 2025
zvookin
reviewed
Nov 19, 2025
Member
|
Approve pending spelling errors. Thank you for the fix. Seems an obvious thing in retrospect, but such is the issue with not having hardware or a good sim environment to test on. By way of code review, I'm wondering if we should favor having the intrinsic code in a .ll file aded to the runtime rather than generating it in CodeGen_LLVM. Perhaps a question for @abadams or @alexreinking. |
zvookin
approved these changes
Nov 19, 2025
Contributor
Author
I had added it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue that runtime vscale assert never failed whatever vector_bits is set in Target because llvm compiler asserts llvm.vscale value at compile-time and optimize away the runtime call if the function has the attribute of vscale_range(n,m) where n==m.