Skip to content

Comments

Replace Infallible to LambdaError on hyper#13

Open
namse wants to merge 1 commit intohanabu:mainfrom
namse:patch-1
Open

Replace Infallible to LambdaError on hyper#13
namse wants to merge 1 commit intohanabu:mainfrom
namse:patch-1

Conversation

@namse
Copy link

@namse namse commented Sep 1, 2022

Related issue: #12

I replaced Infallible to LambdaError for supporting error handling on hyper.

@hanabu
Copy link
Owner

hanabu commented Jan 8, 2023

Thank you for your contribution.

But, with your change, axum or warp web frameworks can not compile with this.
Both frameworks assume Service with Error=Infallible e.g., axum::Router,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants