Skip to content

Implicit default params#1042

Merged
has2k1 merged 3 commits intomainfrom
implicit-default-params
Mar 10, 2026
Merged

Implicit default params#1042
has2k1 merged 3 commits intomainfrom
implicit-default-params

Conversation

@has2k1
Copy link
Owner

@has2k1 has2k1 commented Mar 10, 2026

No description provided.

has2k1 added 3 commits March 9, 2026 20:53
…ase class defaults

Every geom and stat subclass repeated the same stat=, position= and
na_rm= entries in DEFAULT_PARAMS. These common keys are now provided
by _BASE_PARAMS on the geom and stat base classes, keeping subclass
DEFAULT_PARAMS focused on parameters unique to each component.
@has2k1 has2k1 merged commit c08425a into main Mar 10, 2026
12 checks passed
@has2k1 has2k1 deleted the implicit-default-params branch March 10, 2026 17:50
@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 88.13559% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.77%. Comparing base (204b4cb) to head (c08425a).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
plotnine/layer.py 50.00% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1042      +/-   ##
==========================================
- Coverage   86.79%   86.77%   -0.03%     
==========================================
  Files         203      203              
  Lines       13816    13820       +4     
  Branches     1706     1710       +4     
==========================================
  Hits        11992    11992              
- Misses       1275     1276       +1     
- Partials      549      552       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant