Handle file renaming - #4957
Open
VeryMilkyJoe wants to merge 2 commits into
Open
Conversation
VeryMilkyJoe
force-pushed
the
rename-decl-imports
branch
3 times, most recently
from
June 7, 2026 15:32
5fd8c21 to
1a4dc78
Compare
Add handling of WillRename Notification which changes the module declaration and all imports of the module to rename to the new name.
VeryMilkyJoe
force-pushed
the
rename-decl-imports
branch
from
June 8, 2026 08:08
406eac2 to
95f99f3
Compare
VeryMilkyJoe
force-pushed
the
rename-decl-imports
branch
from
June 8, 2026 11:33
95f99f3 to
e521a2a
Compare
Add handling of WillRename Notification which changes the module declaration and all imports of the module to rename to the new name.
VeryMilkyJoe
force-pushed
the
rename-decl-imports
branch
from
June 8, 2026 12:04
e521a2a to
674a1b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds handling of
WillRenameFileNotification to the rename plugin.When receiving this notification, we:
Note that in the example below, there are errors after renaming because we do not edit the cabal file so the project will not build after a rename.
This is part of the implementation of #4951.
Screencast.From.2026-06-07.15-09-27.mp4