Add displayName to Signature for debugging and JRuby fun#9
Open
enebo wants to merge 1 commit intoheadius:masterfrom
Open
Add displayName to Signature for debugging and JRuby fun#9enebo wants to merge 1 commit intoheadius:masterfrom
enebo wants to merge 1 commit intoheadius:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
displayName seems like it would be a useful field for debugging so at least toString can print out additional info on the signature other than just the types. It also feels missing to me in some way since there is optional support for argNames in Signature already.
My deeper motivation is we pass around info to construct ASM Method and Signature in JRuby's JIT. If we added this field we could then pass around Signature and not have this floating 'name' param along side Signature.