IS-IS Watcher lab

[Vadims06]

No description provided.

[Vadims06]

I also checked that the lab operates as expected accordingly to README file. @mjbear please let me know if I need to change anything in the lab and is it good to merge the request?..

[mjbear]

I also checked that the lab operates as expected accordingly to README file. @mjbear please let me know if I need to change anything in the lab and is it good to merge the request?..

@Vadims06
I'm only a random passerby, Roman (hellt) is the maintainer/owner. Apologies for the confusion.

• A line in prepare.sh refers to isisd.log
• And the isisd.log is still present in the PR

[Vadims06]

• A line in prepare.sh refers to isisd.log
• And the isisd.log is still present in the PR

Removed it in my last commit

[Vadims06]

@hellt, would you be able to review this pull request? I will appreciate that.

[mjbear]

@Vadims06
Without being pesky, could I suggest that watcher.log (even an empty file) is not committed to version control?

Here's a suggestion on creating the file if it does not exist (locally, not included in version control).
Additionally we can have logic to truncate the file when rebuilding/re-running prepare.sh.

Is this cool? 😎 😅
(If you approve my suggestion, please click the "commit suggestion" button to accept it. Thank you!)

Suggested change

	sudo chown systemd-network:systemd-journal watcher/watcher.log
	if [ ! -f watcher/watcher.log ]; then
	touch watcher/watcher.log
	fi
	# reset the log file to a clean slate
	truncate -s0 watcher/watcher.log
	sudo chown systemd-network:systemd-journal watcher/watcher.log

[Vadims06]

Thanks! I added it to prepare.sh

[Vadims06]

(If you approve my suggestion, please click the "commit suggestion" button to accept it. Thank you!)

Opps, I've noticed it after I'd pushed this change :(

[mjbear]

@Vadims06
I raise you Vadims06#1 ♟️ 😅

Please consider merging it into your branch so it becomes part of this PR. Thank you!

[Vadims06]

@mjbear many thanks for your valuable comments!
@hellt is it good to proceed?)

[Vadims06]

telemetry/isis-watcher.md doc link is added

[hellt]

there is a broken link to the image @Vadims06

[mjbear]

there is a broken link to the image @Vadims06

@Vadims06
I worked up the image path for telemetry that should work.
Here's a PR Vadims06#2

[Vadims06]

there is a broken link to the image @Vadims06

Link to the image has been fixed

[hellt]

WARNING - Doc file 'telemetry/isis-watcher.md' contains a relative link '../../labs/isis-watcher/container_lab.drawio.png', but the target '../labs/isis-watcher/container_lab.drawio.png' is not found among documentation files.

[mjbear]

WARNING - Doc file 'telemetry/isis-watcher.md' contains a relative link '../../labs/isis-watcher/container_lab.drawio.png', but the target '../labs/isis-watcher/container_lab.drawio.png' is not found among documentation files.

@hellt @Vadims06 Apologies ... when it renders on GH and you think you're in the clear. 😅

For a moment I wondered if I made a typo, but the image renders successfully on GH.

I would say it's a matter of figuring out what mkdocs is doing or doesn't like.

The tests show the literal link, but at the end of that same line removes one of the double dots (after "but the target") to move to the parent directory.

WARNING -  Doc file 'telemetry/isis-watcher.md' contains a relative link '../../labs/isis-watcher/container_lab.drawio.png', but the target '../labs/isis-watcher/container_lab.drawio.png' is not found among documentation files.

Aborted with 1 warnings in strict mode!
Error: Process completed with exit code 1.

[Vadims06]

probably it's needed to move an image into image folder...

[mjbear]

probably it's needed to move an image into image folder...

You might be on to something @Vadims06.
Mkdocs probably focuses on the docs dir.

If you move your image to docs/images, you should still be able to utilize that image for your lab specific Markdown.

That lab path could be ../../docs/images/container_lab.drawio.png

Give it a shot, I'm rooting for a solution! 😀

[hellt]

The issue with the picture was that it was not a png, but a drawio file.
I screenshotted it and uploaded to Internet to fix this. Ideally it would've been added as a drawio integration, but it is not a mandatory requirement either, so good with me.

[mjbear]

The issue with the picture was that it was not a png, but a drawio file. I screenshotted it and uploaded to Internet to fix this. Ideally it would've been added as a drawio integration, but it is not a mandatory requirement either, so good with me.

Thank you Roman!

[Vadims06]

Thanks a lot Roman and Michael!