Use standard std::shared_lock for C++14
#1651
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the `std::shared_mutex` is C++17, the lock implementation was added in C++14 Relates-To: MINOR Signed-off-by: Andrey Kashcheev <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1651 +/- ##
==========================================
+ Coverage 80.33% 80.36% +0.03%
==========================================
Files 350 350
Lines 14039 14041 +2
Branches 1515 1516 +1
==========================================
+ Hits 11278 11284 +6
+ Misses 2147 2144 -3
+ Partials 614 613 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mykolamalik
approved these changes
Dec 24, 2025
rustam-gamidov-here
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the
std::shared_mutexis C++17, the lock implementation was added in C++14Relates-To: MINOR