find_kernel: initialize the allocator based on the start address for unrelocatable kernels - #378
find_kernel: initialize the allocator based on the start address for unrelocatable kernels#378cagatay-y wants to merge 1 commit into
Conversation
…unrelocatable kernels
mkroening
left a comment
There was a problem hiding this comment.
I am not sure why initializing PhysAlloc after the mapping works, as the mapping functions seem to depend on it.
That is only true if there are no additional page tables (and thus physical frames) needed to perform the mapping. See Mapper::map_to_with_table_flags
We are also moving away from unrelocatable kernels. We now support relocatable GCC-based kernels: hermit-os/hermit-entry#37
|
We are not interested in supporting any feature that is not needed by hermit, right? In that case we can remove the part for adjusting the start address based on the ELF object. Should we still add a check to see if the kernel expects to be located at a certain address and error if that's the case? |
|
Thanks a lot! This should no longer be necessary as of: |
I am not sure why initializing PhysAlloc after the mapping works, as the mapping functions seem to depend on it.