Skip to content

Conversation

@hyoban
Copy link

@hyoban hyoban commented Jan 27, 2026

When the original file has many errors, we need to run it multiple times.

@mrlubos
Copy link
Member

mrlubos commented Jan 27, 2026

@hyoban can you explain what does this solve? It's not clear what issue it fixes by not throwing immediately

@hyoban
Copy link
Author

hyoban commented Jan 27, 2026

A file may have many missing references. If an error is thrown immediately, we cannot fix all errors at once; we can only fix the current error and rerun the script.

@mrlubos
Copy link
Member

mrlubos commented Jan 27, 2026

Is there an easy way to write a test for this behavior? I know this package is in a bad shape so no worries if not. Do you have a spec you're testing with where you ran into this problem?

@hyoban
Copy link
Author

hyoban commented Jan 28, 2026

Here is an example. Because of historical issues on the backend, it has a lot of reference errors. If we can't know all of them in advance, we can only fix them one by one.

https://gist.github.com/hyoban/2779870e631b91085a66eef074646d20

Warning: Missing pointer "WorkflowExecutionStatus" in path "/Users/hyoban/i/dify/open-api/console-api.json#/definitions/WorkflowExecutionStatus".
Warning: Missing pointer "DatasetPermissionEnum" in path "/Users/hyoban/i/dify/open-api/console-api.json#/definitions/DatasetPermissionEnum".
Warning: Missing pointer "InfoList" in path "/Users/hyoban/i/dify/open-api/console-api.json#/definitions/InfoList".
Warning: Missing pointer "NotionInfo" in path "/Users/hyoban/i/dify/open-api/console-api.json#/definitions/NotionInfo".
Warning: Missing pointer "FileInfo" in path "/Users/hyoban/i/dify/open-api/console-api.json#/definitions/FileInfo".
Warning: Missing pointer "WebsiteInfo" in path "/Users/hyoban/i/dify/open-api/console-api.json#/definitions/WebsiteInfo".
Warning: Missing pointer "NotionPage" in path "/Users/hyoban/i/dify/open-api/console-api.json#/definitions/NotionPage".
Warning: Missing pointer "NotionIcon" in path "/Users/hyoban/i/dify/open-api/console-api.json#/definitions/NotionIcon".
Warning: Missing pointer "RerankingModel" in path "/Users/hyoban/i/dify/open-api/console-api.json#/definitions/RerankingModel".
Warning: Missing pointer "DataSource" in path "/Users/hyoban/i/dify/open-api/console-api.json#/definitions/DataSource".
Warning: Missing pointer "LoadBalancingPayload" in path "/Users/hyoban/i/dify/open-api/console-api.json#/definitions/LoadBalancingPayload".

@mrlubos mrlubos merged commit 7d2e8bc into hey-api:main Jan 28, 2026
12 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants