fix: request draining for early 413 responses#329
Merged
Conversation
…bleStream controller conflict on Node.js v20
Member
Author
|
Hi @yusukebe, I believe this change will resolve the issue where the connection is lost before the 413 response is sent. Since the changes are limited in scope, I don’t believe they will affect responses to normal requests. Could you please review this? |
Member
|
@usualoma Okay! I'll check it later. |
usualoma
force-pushed
the
fix-connect-error
branch
3 times, most recently
from
cf51c02 to
3fe7cae
Compare
usualoma
force-pushed
the
fix-connect-error
branch
from
3fe7cae to
beabf24
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #327