Skip to content

get actual cpu count instead of just launching 8 processes.#39

Open
matthiaskrgr wants to merge 1 commit intohoxu:masterfrom
matthiaskrgr:master
Open

get actual cpu count instead of just launching 8 processes.#39
matthiaskrgr wants to merge 1 commit intohoxu:masterfrom
matthiaskrgr:master

Conversation

@matthiaskrgr
Copy link
Copy Markdown

I noticed that gitstats would launch 8 processes on my dualcore machine.
My commit changes it so that we only launch as much processes as we actually have cores.

@hoxu
Copy link
Copy Markdown
Owner

hoxu commented Nov 7, 2014

Hello Matthias,

Did you actually run (clean) benchmarks to find out the optimal amount
of processes for your setup?

I dug up some old e-mail threads from when multiprocessing was added,
and my personal finding was that the performance was not optimal with
1:1 cores:processes ratio at least :)

Probably because a lot of stuff is not cpu-bound, but I haven't dug
deeper to really understand where the bottleneck usually is.

Would be nice to see more empirical data before changing the default.
Possibly processes = 2*cores could be a good default.

Regards,

Heikki Hokkanen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants