fix: decode percent-encoded credentials in URL userinfo #1684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When percent-encoded characters are used in the username/password part of a URL, they should be decoded before being used for authentication. For example, `u%40d` should be decoded to `u@d` before Basic auth. Fixes httpie#1623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1623
Problem
When credentials contain special characters and are percent-encoded in the URL
(e.g.,
https://u%40d:p%[email protected]), HTTPie uses them literally withoutdecoding, causing authentication failures.
Reproduction
Solution
Added
urllib.parse.unquote()to decode username and password extracted fromURL before using them for authentication.