fix: Allow options to appear before URL (#1592)#1708
Open
plausibleCoder wants to merge 1 commit intohttpie:masterfrom
Open
fix: Allow options to appear before URL (#1592)#1708plausibleCoder wants to merge 1 commit intohttpie:masterfrom
plausibleCoder wants to merge 1 commit intohttpie:masterfrom
Conversation
themavik
reviewed
Mar 23, 2026
themavik
left a comment
There was a problem hiding this comment.
nit: Splitting argv with startswith('-') still treats values that belong to flags (the token right after --auth, etc.) as positionals, so those tokens get moved ahead of flags and argparse can mis-parse. nit: The "# In parse_args method" line is three-space-indented next to four-space code—looks like a stray edit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request fixes issue #1592.
I have added a pre-parsing step that reorders the command-line arguments. This ensures that positional arguments (METHOD and URL) are moved to the front of the list, ahead of any optional arguments.
This allows the default argument parser to correctly handle commands like https GET --verify=no pie.dev/get, which previously failed.
I have confirmed locally that the fix works and the previously failing command now succeeds.