Fix CogVideoX dynamic CFG to use loop index instead of timestep value#13172
Open
veeceey wants to merge 1 commit intohuggingface:mainfrom
Open
Fix CogVideoX dynamic CFG to use loop index instead of timestep value#13172veeceey wants to merge 1 commit intohuggingface:mainfrom
veeceey wants to merge 1 commit intohuggingface:mainfrom
Conversation
The dynamic CFG calculation was using t.item() (timestep value, range 1-999) where it should use the loop index i (range 0 to num_inference_steps-1). This caused the cosine schedule to produce wildly oscillating guidance values instead of a smooth annealing from guidance_scale+1 down to 1. Fixes huggingface#9641
Contributor
Author
Manual Test ResultsVerified the dynamic CFG schedule with Before fix (oscillating wildly due to After fix (smooth cosine annealing from 5.0 down to 1.0): Also fixed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dynamic CFG calculation in CogVideoX pipelines was using
t.item()(the raw timestep value, which ranges from ~1 to ~999) instead of the loop indexi(which ranges from 0 tonum_inference_steps - 1). This made((num_inference_steps - t.item()) / num_inference_steps)go deeply negative, and after** 5.0+math.cos, the guidance scale oscillates wildly instead of following a smooth cosine annealing schedule.Replaced
t.item()withiin all four CogVideoX pipeline files:pipeline_cogvideox.pypipeline_cogvideox_image2video.pypipeline_cogvideox_video2video.pypipeline_cogvideox_fun_control.pyQuick sanity check with
guidance_scale=4, num_inference_steps=50:Fixes #9641