Skip to content

Conversation

@MikeShi42
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2026

⚠️ No Changeset found

Latest commit: dcf92b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview, Comment Jan 23, 2026 0:34am

Request Review

@claude
Copy link

claude bot commented Jan 23, 2026

PR Review: Make search page more mobile friendly

Critical Issues:

  • Inconsistent useLocalStorage API usage (DBSearchPage.tsx:855) → The custom useLocalStorage in utils.ts takes 2 positional params (key, initialValue), but AppNav.tsx uses Mantine's useLocalStorage with object param {key, defaultValue}. Line 855 uses positional params but mixes with variable default value - verify which useLocalStorage is imported and use consistent API.

  • ⚠️ Duplicate screen size calculationisSmallScreen computed in both DBSearchPage.tsx (line 850) and AppNav.tsx (line 453) with same logic. This logic shouldn't be duplicated - consider extracting to shared hook or constant.

  • ⚠️ ActionIcon missing required variant (DBSearchPageFilters.tsx:1179, 1186) → Code style guide requires Button/ActionIcon to use variant="primary", variant="secondary", or variant="danger". The ActionIcons use variant="subtle" which is not in the allowed list. Change to appropriate custom variant.

Minor Notes:

  • The isFiltersCollapsed = isFiltersPreferCollapsed assignment (line 857) is unnecessary indirection - just use isFiltersPreferCollapsed directly throughout the component.

✨ Generated by Claude Code

@github-actions
Copy link
Contributor

E2E Test Results

All tests passed • 61 passed • 4 skipped • 793s

Status Count
✅ Passed 61
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 4

Tests ran across 4 shards in parallel.

View full report →

@MikeShi42 MikeShi42 marked this pull request as draft January 23, 2026 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants