Fix GH-22158: JIT observer dispatch through wrong run_time_cache slot#80
Closed
iliaal wants to merge 1 commit into
Closed
Fix GH-22158: JIT observer dispatch through wrong run_time_cache slot#80iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
For a megamorphic call the tracing JIT built the observer handler pointer with the ir_PHI_2 operands reversed relative to the ir_MERGE_WITH predecessor order, so a user function read the internal_function_extension slot instead of op_array_extension. When an extension reserves an op_array handle before the observer registers the two indices differ, that slot holds 0, and the JIT calls a NULL begin handler. The default-off zend_test.observer.reserve_op_array_handle INI forces that index mismatch so the regression test can reproduce the crash. Fixes phpGH-22158
iliaal
force-pushed
the
fix/gh-22158-jit-observer-phi
branch
from
db91326 to
eee5fc0
Compare
Owner
Author
|
Submitted upstream: php#22258. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Megamorphic observer dispatch in the tracing JIT read the wrong run_time_cache slot: the ir_PHI_2 operands were reversed against the ir_MERGE_WITH predecessor order, so a user function picked up the internal_function_extension slot. With op_array_extension != internal_function_extension (some extension reserves an op_array handle before the observer registers, e.g. an APM extension) that slot holds 0 and the JIT calls a NULL begin handler. The regression test adds a default-off zend_test.observer.reserve_op_array_handle to force the mismatch in-tree.
Fixes php#22158