refactor(audience-sdk): drop response-body cap on OnError messages#713
Merged
ImmutableJeffrey merged 1 commit intofeat/audience-sample-appfrom Apr 28, 2026
Conversation
Removes MaxErrorBodyChars (500) and the trim ternary inside ReadBodyForErrorAsync. The cap was defensive against verbose backend responses (stack traces, HTML error pages) but the audience backend returns short structured JSON for both 4xx and 5xx, making the cap dead code. Consumers now see the full response body verbatim.
nattb8
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the 500-char
MaxErrorBodyCharscap and the trim ternary insideReadBodyForErrorAsyncinHttpTransport. The cap was defensive against verbose backend responses (stack traces, HTML error pages) but the audience backend returns short structured JSON for both 4xx and 5xx, making the cap dead code. Consumers now see the full response body verbatim inOnErrormessages.Stacked on top of #711. Base =
feat/audience-sample-app. Once 711 merges, this PR's base will auto-rebase tomain.Linear: SDK-152