fix: add rel=noopener noreferrer to external links in Footer#608
Open
amathxbt wants to merge 1 commit intoinkonchain:mainfrom
Open
fix: add rel=noopener noreferrer to external links in Footer#608amathxbt wants to merge 1 commit intoinkonchain:mainfrom
amathxbt wants to merge 1 commit intoinkonchain:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The
Footercomponent renders two external links withtarget="_blank"but norelattribute:Opening a link with
target="_blank"withoutrel="noopener"gives the opened page access to the opener viawindow.opener. This enables a reverse tabnapping attack where a malicious or compromised destination page can redirect the original tab to a phishing page.Although modern browsers set
rel="noopener"implicitly for cross-origin navigations since Chrome 88 / Firefox 79, the explicit attribute is still required for:jsx-a11y/anchor-is-valid,react/jsx-no-target-blank)Fix
Add
rel="noopener noreferrer"to both links:noreferreradditionally prevents theRefererheader from leaking the docs URL to the destination.