fix: replace awk-based .env parsing with read loop to handle values containing spaces#83
Open
amathxbt wants to merge 1 commit intoinkonchain:mainfrom
Open
fix: replace awk-based .env parsing with read loop to handle values containing spaces#83amathxbt wants to merge 1 commit intoinkonchain:mainfrom
amathxbt wants to merge 1 commit intoinkonchain:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
progress.shloads.envusingawkfield splitting:awksplits on whitespace by default. This means any.envvalue that contains a space is silently truncated:Additionally:
grep -v '#'strips entire lines containing#anywhere, not just comment lines — it would incorrectly stripSOME_KEY=value#tag|| error_exitguard never fires on parsing errors becauseexportof an empty string list succeeds silentlyexport $(...)with word-split output is fragile: if a value accidentally contains shell metacharacters, it can cause unexpected behaviourFix
Replace the one-liner with a
while readloop that processes the file line-by-line, correctly skipping blank lines and comment lines while exporting each assignment verbatim:This correctly handles:
KEY=value with spaces)|| [ -n "$line" ]condition)