Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #62 +/- ##
=========================================
Coverage 98.08% 98.08%
Complexity 253 253
=========================================
Files 10 10
Lines 627 627
=========================================
Hits 615 615
Misses 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…instead of "latest". This change is needed because with WP 6.8 (latest in May 2025), the static analysis fail due invalid code in PHP 7.4. See also: php-stubs/wordpress-stubs#277
tfrommen
approved these changes
May 9, 2025
Member
tfrommen
left a comment
tfrommen
left a comment
There was a problem hiding this comment.
Are we tracking anywhere that we need/want to revert to latest as soon as possible?
Otherwise, this is looking good. 👍
Member
Author
|
Just internal. I'll set myself a reminder to check regarding the releases, but I've also left a note in the commit so that we know why it is 6.7 fixed. 💪🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR will remove the restriction of PHP
<8.4to support PHP 8.4.Right now, the static analysis for PHP 7.4 is failing. No code was changed, so it seems like the error is happening in a different location. I've also tested PHPStan 2.1.7, which worked before (2 months ago) but now also fails. Same as the latest version 2.1.14. The only thing that has changed in between is the WordPress version (using
latest.phpfrom inpsyde/wp-stubs).I've decided to move the PHP 8.4 to a separate step for PHP Unit Testing. The "dependency-versions" with "lowest" will not work with PHP 8.4 due to missing support (Mockery, Patchwork, ...).