Skip to content

feat: add credential request by modules endpoint#62

Draft
Bram Winter (winterworks) wants to merge 4 commits into
mainfrom
add-credential-request-by-modules-endpoint
Draft

feat: add credential request by modules endpoint#62
Bram Winter (winterworks) wants to merge 4 commits into
mainfrom
add-credential-request-by-modules-endpoint

Conversation

@winterworks

Copy link
Copy Markdown
Contributor

Add credential request by modules endpoint.
Also ran format on all files.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Credential Requests API capability to create requests from app/module selections (v2 endpoint), plus an accompanying MCP tool definition, and updates tests/mocks. The PR also includes broad formatting-only changes across several files.

Changes:

  • Add credentialRequests.createByModules(...) API method + exported types for the provider/body shapes.
  • Add MCP tool credential-requests_create-by-modules with a JSON schema for provider selection (existing Make user vs new user invite).
  • Add/extend unit + integration test coverage and a new mock response fixture.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/on-prem-tools.spec.ts Formatting-only change to a mockFetch(...) call.
test/mocks/credential-requests/create-by-modules.json New mock payload for the v2 “create by modules” endpoint response.
test/credential-requests.spec.ts Adds unit tests for createByModules; updates provider shape usage; formatting.
test/credential-requests.integration.test.ts Adds integration coverage for createByModules + cleanup via delete.
test/connected-systems.utils.ts Formatting-only change in error message construction.
test/connected-systems.utils.spec.ts Formatting-only import consolidation.
test/connected-systems.integration.test.ts Formatting-only changes to imports and call sites.
src/index.ts Re-exports new credential-request-related types.
src/endpoints/on-prem-agents.ts Formatting-only signature/body formatting.
src/endpoints/on-prem-agents.tools.ts Formatting-only execute signature formatting.
src/endpoints/enums.ts Formatting-only return formatting.
src/endpoints/credential-requests.ts Adds provider/body types + createByModules method; adjusts typing of provider.
src/endpoints/credential-requests.tools.ts Adds MCP tool definition for credential-requests_create-by-modules.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/endpoints/credential-requests.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants