-
Notifications
You must be signed in to change notification settings - Fork 802
[SYCL] Remove unnecessary fallback-cassert file for CUDA/AMD assert #20967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
|
Hi, @intel/llvm-gatekeepers |
|
I can't see this affecting Intel Arc testing, so my assumption is that it's either sporadic or that there has been some environment changes that causes this to now pass. I will merge it, then we can revert if my assumptions are wrong. Tag @dkhaldi |
We have removed fallback device library jit-link path, so there is no need to have separate libsycl-fallback-* library files. The only exception is imf libraries for SPIRV targets.
This PR is a series of patches to clean up all unnecessary libsycl-fallback-* library files exposing _devicelib* APIs, we clean up libsycl-fallback-cassert for CUDA/AMD target.
For Intel Target, the __devicelib_assert_fail is provided by IGC or OpenCL CPU runtime and for AMD/CUDA target, underlying runtime provides similar function '__assertfail'.