Skip to content

Conversation

@jinge90
Copy link
Contributor

@jinge90 jinge90 commented Dec 24, 2025

We have removed fallback device library jit-link path, so there is no need to have separate libsycl-fallback-* library files. The only exception is imf libraries for SPIRV targets.
This PR is a series of patches to clean up all unnecessary libsycl-fallback-* library files exposing _devicelib* APIs, we clean up libsycl-fallback-cassert for CUDA/AMD target.
For Intel Target, the __devicelib_assert_fail is provided by IGC or OpenCL CPU runtime and for AMD/CUDA target, underlying runtime provides similar function '__assertfail'.

@jinge90 jinge90 requested a review from a team as a code owner December 24, 2025 05:19
@jinge90 jinge90 requested a review from againull December 24, 2025 05:19
@jinge90 jinge90 marked this pull request as draft December 24, 2025 05:46
@jinge90 jinge90 marked this pull request as ready for review December 24, 2025 06:32
Signed-off-by: jinge90 <[email protected]>
@jinge90
Copy link
Contributor Author

jinge90 commented Jan 5, 2026

Hi, @intel/llvm-gatekeepers
These is an unexpected pass in pre-ci:
Unexpectedly Passed Tests (1):
SYCL :: Matrix/joint_matrix_bf16_fill_k_cache_SLM.cpp
Is it a known issue?
Thanks very much.

@steffenlarsen
Copy link
Contributor

I can't see this affecting Intel Arc testing, so my assumption is that it's either sporadic or that there has been some environment changes that causes this to now pass. I will merge it, then we can revert if my assumptions are wrong.

Tag @dkhaldi

@steffenlarsen steffenlarsen merged commit 8f04eb2 into intel:sycl Jan 5, 2026
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants