[SYCL][NFC] Update some ESIMD tests - #22944
Open
KornevNikita wants to merge 1 commit into
Open
Conversation
These tests are disabled on PVC because there are seperate versions of these tests for PVC.
sarnex
approved these changes
Aug 14, 2026
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // UNSUPPORTED: arch-intel_gpu_pvc | ||
| // REQUIRES: !arch-intel_gpu_pvc |
Contributor
There was a problem hiding this comment.
nit: can we put the new comment above the REQUIRES? its not worth manually updating, see if you can get an LLM to do it. if not, just ignore this comment
sergey-semenov
approved these changes
Aug 14, 2026
bader
reviewed
Aug 14, 2026
| // | ||
| // UNSUPPORTED: arch-intel_gpu_pvc | ||
| // REQUIRES: !arch-intel_gpu_pvc | ||
| // There is a separate version of this test for PVC. |
Contributor
There was a problem hiding this comment.
The guide says you should use UNSUPPORTED + UNSUPPORTED-INTENDED for such cases.
Suggested change
| // There is a separate version of this test for PVC. | |
| // UNSUPPORTED-INTENDED: There is a separate version of this test for PVC. |
Contributor
There was a problem hiding this comment.
Can you link the guide? I didn't know we had a rule for this
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
thanks for the link, i will make sure to honor this in the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests are disabled on PVC because there are seperate versions of these tests for PVC.