Skip to content

feat(ui): add Generate tab Upscale controls#9126

Open
AsuraAce wants to merge 6 commits intoinvoke-ai:mainfrom
AsuraAce:codex/generate-upscale-hrf-pr
Open

feat(ui): add Generate tab Upscale controls#9126
AsuraAce wants to merge 6 commits intoinvoke-ai:mainfrom
AsuraAce:codex/generate-upscale-hrf-pr

Conversation

@AsuraAce
Copy link
Copy Markdown

@AsuraAce AsuraAce commented May 5, 2026

Summary

This PR adds Generate-tab Upscale controls backed by the existing High Resolution Fix graph path.

It includes:

  • a Generate-tab Upscale accordion with Latent and Upscale Model methods
  • graph generation for latent HRF and model-based upscaling/refinement, including tiled VAE decode for the final latent decode
  • model-family gating so Generate Upscale is visible/applied only for supported SD1.5 and SDXL bases
  • preservation of hidden Upscale settings when users temporarily switch to unsupported model families
  • metadata and recall support for HRF settings, refinement model, and dedicated HRF LoRAs
  • Recall Parameters behavior that recalls the base generation size and leaves final output dimensions to Image Details
  • UI polish for disabled-but-configurable Upscale settings and grouped refinement model selection

The main user impact is that Generate users can configure an upscale/refinement pass directly from the Generate tab, then recall/remix images using the original base generation dimensions plus the saved Upscale settings.

View screenshots image
image

Related Issues / Discussions

N/A

QA Instructions

Focused automated checks run locally:

pnpm vitest --run src/features/nodes/util/graph/generation/addHighResFix.test.ts src/features/gallery/components/ImageMetadataViewer/ImageMetadataActions.test.tsx src/features/metadata/parsing.test.ts src/features/metadata/parsing.test.tsx src/features/controlLayers/store/paramsSlice.test.ts src/features/queue/store/readiness.test.ts
pnpm lint:tsc
pnpm lint:eslint
pnpm lint:prettier
git diff --check

Manual smoke coverage performed locally:

  • Generate tab Upscale settings render while disabled and preserve configured values when enabled
  • Latent HRF uses tiled final decode and avoids the previous VRAM issue
  • Upscale Model HRF generates and metadata recall uses the base generation size
  • Recall Parameters list the HRF refinement model and dedicated HRF LoRAs
  • Unsupported model families hide/ignore stale Upscale settings without clearing them
  • Generation queue smoke test passed with a single active backend for the Invoke root

Merge Plan

No special merge sequencing is required. This touches persisted Generate params and includes the corresponding migration/test coverage.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • ❗Changes to a redux slice have a corresponding migration
  • Documentation added / updated (not applicable)
  • Updated What's New copy (not applicable)

@github-actions github-actions Bot added python PRs that change python files invocations PRs that change invocations frontend PRs that change frontend files labels May 5, 2026
@AsuraAce AsuraAce changed the title [codex] Add Generate tab Upscale controls feat(ui): add Generate tab Upscale controls May 5, 2026
@AsuraAce AsuraAce marked this pull request as ready for review May 5, 2026 16:35
@AsuraAce AsuraAce marked this pull request as draft May 5, 2026 19:11
@AsuraAce
Copy link
Copy Markdown
Author

AsuraAce commented May 5, 2026

I found one more support-scope issue while smoke testing: latent Upscale is currently exposed for non-SD model families like ANIMA. I’m moving this back to draft briefly to tighten supported model gating before review.

@AsuraAce AsuraAce marked this pull request as ready for review May 6, 2026 11:44
@lstein lstein added the 6.14.x label May 7, 2026
@lstein lstein moved this to 6.14.x Theme: LIBRARY UPDATES in Invoke - Community Roadmap May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.14.x frontend PRs that change frontend files invocations PRs that change invocations python PRs that change python files

Projects

Status: 6.14.x Theme: LIBRARY UPDATES

Development

Successfully merging this pull request may close these issues.

3 participants