Repository navigation
chore(ci): Update macOS and Xcode - #2633
Conversation
| - run: xcrun simctl list > /dev/null | ||
| - run: xcodebuild -downloadPlatform iOS |
There was a problem hiding this comment.
I didn't check but perhaps in this new runner these couple of lines aren't needed anymore?
Doesn't need to be addressed in this PR but just thought of it.
There was a problem hiding this comment.
might not be needed now, but since we stick to 27.0 for the whole year, they will most likely remove olde simulators when they add new ones
There was a problem hiding this comment.
Doesn't seem like CI ran with updated Xcode version because there are no plugin changes, just checking if we've done that or not, otherwise can we be sure that the CI is working?
I suppose we can find that out whenever we make plugin changes in the future, but doesn't hurt to check now?
There was a problem hiding this comment.
check how? make some change in all plugins and then revert it?
There was a problem hiding this comment.
I've done that in the past myself yeah. Since we're squashing commits it doesn't really reflect in the end result.
But if you think it's not necessary then it can be merged as-is. I'll approve the PR.
There was a problem hiding this comment.
I've run verify:ios locally with Xcode 27.0 and it built correcly, so I think we are fine.
No description provided.