RNMT-9 fix: use Long for offset to support files larger than 2.14GB - #10
Open
anfuerer wants to merge 4 commits into
Open
RNMT-9 fix: use Long for offset to support files larger than 2.14GB#10anfuerer wants to merge 4 commits into
anfuerer wants to merge 4 commits into
Conversation
added 3 commits
March 10, 2026 22:35
Change offset from Int to Long in IONFILEReadInChunksOptions and IONFILEReadOptions to prevent integer overflow when reading files beyond the ~2.14GB Int.MAX_VALUE boundary.
Uses a sparse file (no actual 2GB+ disk allocation) to test that reading with an offset beyond Int.MAX_VALUE returns the correct content.
Author
|
@OS-pedrogustavobilro would you mind having a look at this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change
offsetparameter type fromInttoLonginIONFILEReadOptionsandIONFILEReadInChunksOptionsto fix file corruption when reading files larger than 2.14GB using chunking.Context
When reading files larger than ~2.14GB (
Int.MAX_VALUEbytes), theIntoffset would overflow, causing incorrect seek positions and corrupt reads. ChangingoffsettoLongallows addressing positions beyond the 2.14GB boundary.Type of changes
Platforms affected
Tests
Added a test in
IONFILELocalFilesHelperTestthat creates a sparse file larger than 2GB (no actual disk allocation), writes known content at an offset beyondInt.MAX_VALUE, and verifies thatreadFileInChunksreturns the correct content when called with that offset.Checklist
RNMT-XXXX <title>