test(angular): register Ionic components on the landing page - #31367
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ShaneK
force-pushed
the
fix/angular-landing
branch
from
August 19, 2026 12:52
bab9321 to
b4899d3
Compare
ShaneK
changed the title
brandyscarney
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Currently, the Angular test app's landing page renders as unstyled inline text on the Vercel preview. It relied on
AppModule'sIonicModulescope for itsion-*directives, but/is only rendered by the standalone bootstrap, soIonicModule.forRoot()'sdefineCustomElements()initializer never runs, and nothing registers those elements once a build tree-shakes the unused standalone proxies.What is the new behavior?
The landing page is now standalone and imports the components it renders, so it registers its own custom elements. The route uses
loadComponentinstead ofcomponentto keep that standalone build out of the lazy app's eager graph.Does this introduce a breaking change?
Other information
Major 9.0's Angular Landing Page
This PR's Angular Landing page link