fix: rename .eslintrc.js to .eslintrc.cjs in esm projects#1786
Open
RuggMatt wants to merge 1 commit intoionic-team:mainfrom
Open
fix: rename .eslintrc.js to .eslintrc.cjs in esm projects#1786RuggMatt wants to merge 1 commit intoionic-team:mainfrom
RuggMatt wants to merge 1 commit intoionic-team:mainfrom
Conversation
27medkamal
approved these changes
Oct 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ionic-team/ionic-cli#5015
Currently, Running
npm run lintin thevue-viteandreact-vitestarter projects is broken.ESLint fails to properly parse the
.eslintrc.jsfile in these two starter projects because it relies on the nearest package.json file to infer whether to interpret.jsfiles as ES Modules or a CommonJS ones. The nearest package.json states:"type": "module". As such, node attempts to parse the.eslintrc.jsfile as an ES Module, and fails. The error message suggests either converting the file to an ES Module, or renaming the file to.eslintrc.cjsto explicitly declare it is a CommonJS file. I've chosen to do the latter.This PR fixes the issue in both starter projects.
npm run lintworks now! 🎉