Conversation
nikatza
force-pushed
the
lldp
branch
5 times, most recently
from
d402159 to
119f0d3
Compare
hardikdr
added
the
area/metal-automation
nikatza
force-pushed
the
lldp
branch
2 times, most recently
from
371767c to
4b23b36
Compare
Add core types to configure Link-Layer Discovery Protocol on devices. The type includes a system-wide setting to enable and disable LLDP. Following OpenConfig design, this type allows per-interface configuration (enable/disable). Notice that the interaction of global and per-interface settings may differ on each platform and provider implementation. Also, some platforms like NXOS allow configuring more settings than those defined in OpenConfig, e.g., disable or enable receive and transmit. This is currently not required by our use case. If this is ever needed this API will need to change.
The controller validates that the referenced Device exists and is not paused, that ProviderConfigRef (if specified) points to a supported provider-specific configuration, and that all InterfaceRefs belong to the same device. It also ensures only one LLDP resource exists per device. During reconciliation, the controller sets the device label and owner reference on the LLDP resource, then calls the provider to apply the LLDP configuration and retrieve operational status. The controller watches for Device Paused field changes and ProviderConfig updates to trigger re-reconciliation when dependencies change. Periodic polling via RequeueInterval ensures operational status stays updated.
Add LLDPConfig CRD for Cisco NX-OS specific LLDP settings that extend the core LLDP configuration. This resource can be referenced via the ProviderConfigRef field in the LLDP spec. The LLDPConfig allows setting InitDelay, the number of seconds to wait before LLDP starts sending packets after an interface comes up, and HoldTime, the duration in seconds that receiving devices should retain LLDP information before discarding it.
Enable or disable the LLDP feature based on the AdminState in the spec. When enabled, configure per-interface Tx/Rx settings based on the InterfaceRefs. The core API does not distinguish between Tx and Rx, so both are set to the same value. If a LLDPConfig is referenced via ProviderConfigRef, apply the InitDelay and HoldTime settings. On deletion, disable the LLDP feature on the device.
Merging this branch changes the coverage (1 decrease, 2 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.