Skip to content

add test for TXT record when vercel and remove invalid files - #48701

Open
gameroman wants to merge 18 commits into
is-a-dev:mainfrom
gameroman:txt-vercel-test
Open

add test for TXT record when vercel and remove invalid files#48701
gameroman wants to merge 18 commits into
is-a-dev:mainfrom
gameroman:txt-vercel-test

Conversation

@gameroman

@gameroman gameroman commented Aug 23, 2026

Copy link
Copy Markdown
Member

Added a test for invalid TXT records and removed invalid ones

@is-a-dev-reviewbot

Copy link
Copy Markdown

Note

Please be aware that you put the pull request on draft mode when you created the pull request. If this isn't intentional, please scroll down until you find the "Ready for review" button and click it. We recommend not opening draft pull requests since we usually ignore it until it's no longer on draft mode.

Hi there! 👋

You've successfully made a pull request! Here are some steps to do while waiting for a maintainer to review the pull request:

  1. Check if the checks have failed or passed. You should see the status at the bottom of the pull request or a icon next to the commit ID. You can click on the 3 dots next to the "CI / Tests" check then click "View details", it will show you the logs of the tests.
  2. Check if the filename, file format, and records are valid. If you don't know if it's valid, please read this part of the documentation and use a JSON validator/formatter, like jsonlint. Make sure that the file is in the domains directory and not somewhere else in the repository.
  3. Please make sure that you've filled out the pull request template. It is generally not a good idea to overwrite the pull request template with something else unless you know what you are doing. Make sure to add either a publicly available preview of your website or a screenshot of it.
  4. Please wait patiently. Pull requests may take between a couple hours to 3 days. All of the maintainer team are volunteers and try to review the pull requests in their spare time.
  5. Please note that mentioning maintainers in pull requests without it being reviewed could lead to you getting marked as "low priority"; this also applies to pinging the maintainers in the Discord server or messaging the maintainers in private to review the pull request.

Note

If you've opened this pull request while there is a high number of other open pull requests, your wait time will be longer than usual. Please be patient!

Note

We have recently launched another free subdomain service, is-a.bot!

Claim your .is-a.bot subdomain on GitHub.

@is-a-dev-bot is-a-dev-bot added ci r: william reason: incomplete pr Your PR template is not complete. (e.g. missing the requirements form, missing website preview) labels Aug 23, 2026
@iostpa iostpa added the ci: bypass-template-check Bypass the PR template check. label Aug 23, 2026
Comment thread tests/records.test.js Outdated
@gameroman
gameroman marked this pull request as ready for review August 23, 2026 17:36
@gameroman
gameroman requested a review from wdhdev as a code owner August 23, 2026 17:36
@gameroman gameroman removed the reason: incomplete pr Your PR template is not complete. (e.g. missing the requirements form, missing website preview) label Aug 23, 2026
@gameroman gameroman changed the title add test for TXT record when vercel add test for TXT record when vercel and remove invalid files Aug 23, 2026
@gameroman
gameroman requested a review from a team as a code owner August 23, 2026 19:58
@is-a-dev-bot is-a-dev-bot added the domain This issue/PR is related to a domain. label Aug 23, 2026
@gameroman gameroman removed the domain This issue/PR is related to a domain. label Aug 23, 2026
@notamitgamer notamitgamer added the ci: bypass-owner-check Bypass the domain ownership check. label Aug 24, 2026
@notamitgamer notamitgamer reopened this Aug 24, 2026
@is-a-dev-bot is-a-dev-bot added the domain This issue/PR is related to a domain. label Aug 24, 2026
@notamitgamer notamitgamer removed the domain This issue/PR is related to a domain. label Aug 24, 2026

@dragsbruh dragsbruh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also remove any parent domains of these domains? only if they also are configured to use vercel ofc

make sure that the they didnt change it to a diff hosting provider later, in which case remove only the _vercel. file and leave parent untouched

would also be a good idea to check if the vercel record is in _vercel.domain.json and not domain.json or _vercel.sub.domain.json or stuff like that

would also recommend pinging owners of any domains you are removing

@gameroman

Copy link
Copy Markdown
Member Author

can you also remove any parent domains of these domains? only if they also are configured to use vercel ofc

make sure that the they didnt change it to a diff hosting provider later, in which case remove only the _vercel. file and leave parent untouched

would also recommend pinging owners of any domains you are removing

I think that's out of scope for this PR currently

would also be a good idea to check if the vercel record is in _vercel.domain.json and not domain.json or _vercel.sub.domain.json or stuff like that

Yeah, I mentioned that in #48701 (comment)

I'd also do that in a separate PR probably

Lets see what @wdhdev thinks

@dragsbruh
dragsbruh dismissed their stale review August 25, 2026 14:01

oh well

@wdhdev wdhdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth modifying the test so require them to be on _vercel nested subdomains & checking it somewhat matches the root subdomain, e.g. if it's on _vercel.william.is-a.dev the verification TXT(s) need to end with .william.is-a.dev or equal william.is-a.dev as nested subdomain Vercel verification records e.g. blog.william.is-a.dev go on _vercel.william.is-a.dev anyway (some people have arrays of TXT records).

Essentially just verify it's on _vercel and that the TXT matches the subdomain or a nested subdomain.

@gameroman

Copy link
Copy Markdown
Member Author

Might be worth modifying the test so require them to be on _vercel nested subdomains & checking it somewhat matches the root subdomain, e.g. if it's on _vercel.william.is-a.dev the verification TXT(s) need to end with .william.is-a.dev or equal william.is-a.dev as nested subdomain Vercel verification records e.g. blog.william.is-a.dev go on _vercel.william.is-a.dev anyway (some people have arrays of TXT records).

Essentially just verify it's on _vercel and that the TXT matches the subdomain or a nested subdomain.

I can do it in this PR or in a follow-up PR

@is-a-dev-bot is-a-dev-bot added the domain This issue/PR is related to a domain. label Aug 27, 2026
@gameroman
gameroman requested a review from wdhdev August 27, 2026 13:56
@wdhdev wdhdev self-assigned this Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: bypass-owner-check Bypass the domain ownership check. ci: bypass-template-check Bypass the PR template check. ci domain This issue/PR is related to a domain. r: william

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants