add test for TXT record when vercel and remove invalid files - #48701
add test for TXT record when vercel and remove invalid files#48701gameroman wants to merge 18 commits into
Conversation
|
Note Please be aware that you put the pull request on draft mode when you created the pull request. If this isn't intentional, please scroll down until you find the "Ready for review" button and click it. We recommend not opening draft pull requests since we usually ignore it until it's no longer on draft mode. Hi there! 👋You've successfully made a pull request! Here are some steps to do while waiting for a maintainer to review the pull request:
Note If you've opened this pull request while there is a high number of other open pull requests, your wait time will be longer than usual. Please be patient! |
There was a problem hiding this comment.
can you also remove any parent domains of these domains? only if they also are configured to use vercel ofc
make sure that the they didnt change it to a diff hosting provider later, in which case remove only the _vercel. file and leave parent untouched
would also be a good idea to check if the vercel record is in _vercel.domain.json and not domain.json or _vercel.sub.domain.json or stuff like that
would also recommend pinging owners of any domains you are removing
I think that's out of scope for this PR currently
Yeah, I mentioned that in #48701 (comment) I'd also do that in a separate PR probably Lets see what @wdhdev thinks |
wdhdev
left a comment
There was a problem hiding this comment.
Might be worth modifying the test so require them to be on _vercel nested subdomains & checking it somewhat matches the root subdomain, e.g. if it's on _vercel.william.is-a.dev the verification TXT(s) need to end with .william.is-a.dev or equal william.is-a.dev as nested subdomain Vercel verification records e.g. blog.william.is-a.dev go on _vercel.william.is-a.dev anyway (some people have arrays of TXT records).
Essentially just verify it's on _vercel and that the TXT matches the subdomain or a nested subdomain.
I can do it in this PR or in a follow-up PR |
c94dcce to
cd42c95
Compare
54dec06 to
6c0ee35
Compare
Added a test for invalid TXT records and removed invalid ones