refactor: use Dependency Groups (PEP 735) instead of misusing package extras for dependencies that are not direct package dependencies#1149
Draft
jenstroeger wants to merge 1 commit intomainfrom
Draft
Conversation
… extras for dependencies that are not direct package dependencies
17c1d75 to
af74dcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For background, see PEP 735 and Dependency Groups. The purpose here is to simplify the package’s API wrt. the package’s deps: previously the dev packages were part of the package’s API via extras, but now we can separate cleanly the package’s API and extra dependencies from the dev packages.
I hope that Dependabot understands these dependency groups 🤓
@behnazh I think we can now simplify the CI build process here
python-package-template/.github/workflows/_build.yaml
Lines 80 to 111 in 17c1d75
Note that we don’t
make prunehere which should save some time. I also think it’s safe to install package deps and then dev deps in two steps, because if the dev deps introduce a package that’s already installed by the package itself and--ignore-installed); orWhat do you think?