Repository navigation
examples: use an in-repo flake in the remote flakes example - #2994
Merged
Merged
Conversation
The flakes/remote example pulled in github:F1bonacc1/process-compose, which isn't in cache.nixos.org, so every CI run built it from source on macOS, including its timing-sensitive Go test suite. That build has repeatedly failed the nightly cli-tests (process-compose 0.43.1 in early September, 1.122.0 now), even though the example's run_test never used process-compose. Point the remote flake at examples/flakes/php/my-php-flake in this repo, pinned to a main commit. Its hello output comes from a locked nixpkgs and is substituted from the binary cache, so nothing is built. run_test now also calls hello so the remote flake is exercised. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
@claude ptal |
|
Claude finished @mikeland73's task in 13s —— View job Review of #2994The change looks good and I didn't find any blocking issues. Checked
Non-blocking notes
LGTM, pending CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/flakes/remotepulled ingithub:F1bonacc1/process-compose. That flake isn't in cache.nixos.org, so every CI run built it from source on macOS, including its Go test suite. The suite's watch/restart tests depend on timing and fail on loaded runners. The example'srun_testnever even used process-compose.This caused the
TestExamples/flakes_remote_run_test.testfailures in the nightly cli-tests:Changes
github:jetify-com/devbox/<main sha>?dir=examples/flakes/php/my-php-flake#hello. That flake has its ownflake.lock, sohellocomes from a pinned nixpkgs and is downloaded from the binary cache instead of built.nixpkgs#hello.run_testnow runshellotoo, so the test actually exercises the remote flake.examples/flakes/README.md, including a note on?dir=for flakes in subdirectories.Test plan
devbox installinexamples/flakes/remote: everything is fetched from cache.nixos.org and nothing buildsDEVBOX_RUN_PROJECT_TESTS=1 go test ./testscripts -run TestExamples/flakes_remotepasses locally (macOS arm64)🤖 Generated with Claude Code