AX-1644- add jfrog mcp no agant guard - like Cursor plugin #23
Merged
Conversation
yanivt-jfrog
changed the title
YoniMelki
previously approved these changes
Jun 24, 2026
Mirrors jfrog/vscode-plugin#28: warn early when JFROG_URL is unset or has a trailing slash before the MCP server fails with a confusing DNS or double-slash error, drop the log prefix so the warnings read as plain user-facing messages, and bump the plugin version so users receive the update. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
YoniMelki
previously approved these changes
Jun 29, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
YoniMelki
approved these changes
Jun 29, 2026
MatanEden1
added a commit
to jfrog/vscode-plugin
that referenced
this pull request
Jun 29, 2026
* AX-1742 — Add JFrog MCP server via .mcp.json (without Agent Guard)
Auto-attach the remote JFrog MCP server (${JFROG_URL}/mcp, OAuth) to every
session via plugin/.mcp.json, mirroring jfrog/claude-plugin#23. Bump plugin
version to 1.0.5 and document the MCP server + trailing-slash note in README.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Warn on missing or trailing-slash JFROG_URL at session start
* Fix JFROG_URL validation: move below force-disable guard and handle JF_URL-only case
- Validation no longer fires for users with Agent Guard force-disabled
- Adds explicit warning when JF_URL is set but JFROG_URL (required by .mcp.json) is not
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Run JFROG_URL validation before the Agent Guard gate
The .mcp.json attaches the JFrog MCP server regardless of whether Agent
Guard is enabled, but the JFROG_URL validation ran after the
agent-guard-enabled gate — so it was skipped in exactly the
"without Agent Guard" case this PR targets, leaving a misconfigured MCP
server with no warning. Move the validation above the gate (still after
force-disable) and document why it reads process.env.* directly.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Warn on missing or trailing-slash JFROG_URL at session start
* Fix JFROG_URL validation: guard endsWith with optional chaining
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* remove log prefix
* Validate JFROG_URL early to prevent connection issues with the MCP server
* Surface JFROG_URL misconfiguration warnings to the user via additionalContext
When JFROG_URL is unset or has a trailing slash, write a hookSpecificOutput
payload so Claude immediately surfaces the warning to the user, in addition
to the existing stderr log. Also set JFROG_URL in the force-enable validator
test so it reaches template injection instead of the new early-exit path.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Remove optional chaining from JFROG_URL trailing slash check for improved validation
* Remove optional chaining from JFROG_URL trailing slash check for improved validation
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.