Skip to content

Shivansh 22866 fix 138 - #495

Open
Shivansh-22866 wants to merge 9 commits into
jtemporal:mainfrom
Shivansh-22866:Shivansh-22866-fix-138
Open

Shivansh 22866 fix 138#495
Shivansh-22866 wants to merge 9 commits into
jtemporal:mainfrom
Shivansh-22866:Shivansh-22866-fix-138

Conversation

@Shivansh-22866

Copy link
Copy Markdown
Contributor

Fixes #138

Migrated the 026 card to mermaid format, from which the EN card is then generated

Copilot AI lite review requested due to automatic review settings August 26, 2026 13:59
@netlify

netlify Bot commented Aug 26, 2026

Copy link
Copy Markdown

Deploy Preview for gitfichas ready!

Name Link
🔨 Latest commit c6c51da
🔍 Latest deploy log https://app.netlify.com/projects/gitfichas/deploys/6a945a2b4fb59200082735c8
😎 Deploy Preview https://deploy-preview-495--gitfichas.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Navigation titles/flags and a descriptor for git branch -D are incorrect (and the PR scope doesn’t match its description), which would publish misleading card content.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR migrates English GitFichas cards to the Mermaid-based post template (front matter + {% include mermaid-graphs.html %}), aligning with the project’s “image → Mermaid” migration workflow referenced by Issue #138.

Changes:

  • Converted en/#026 (and also en/#025) from image-based content to Mermaid post front matter.
  • Added Mermaid metadata (command, descriptors, mermaid: true, use_static_image: true) and removed the legacy HTML/table content.
  • Updated navigation/front matter fields (with a few mismatches noted in review comments).

Please stage the changes and commit both the post changes AND the generated SVG files together.

File summaries
File Description
en/_posts/2021-10-27-026.md Migrates card #26 to Mermaid front matter + include; updates card metadata/descriptors.
en/_posts/2021-10-25-025.md Migrates card #25 to Mermaid front matter + include; adjusts next-card navigation.
Review details
  • Files reviewed: 2/4 changed files
  • Comments generated: 5
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread en/_posts/2021-10-25-025.md Outdated
Comment on lines +25 to +27
nt:
url: "/en/026"
title: "#026 git branch -D nome"
title: "#026 git branch -d nome"
Comment thread en/_posts/2021-10-27-026.md Outdated
Comment on lines +7 to +10
descriptors:
- command: command to manage<br>branches
- part1: flag for deleting<br>the branch locally
- part2: branch name
Comment thread en/_posts/2021-10-25-025.md Outdated
Comment on lines +1 to +14
---
layout: post
title: '#025 git branch -d name'
image: "https://res.cloudinary.com/jesstemporal/image/upload/f_auto/v1642878598/gitfichas/en/025/thumbnail_rv0hvz.jpg"
pretitle: Deleting a
title: branch
subtitle: locally
command: git branch -d name
descriptors:
- command: command to manage<br>branches
- part1: flag for deleting<br>the branch locally
- part2: branch name
author: "@jtemporal"
number: "025"
mermaid: true
use_static_image: true
Comment on lines 15 to 17
permalink: "/en/026"
translations:
- lang: pt
@jtemporal

Copy link
Copy Markdown
Owner

hi @Shivansh-22866 I think this pr got the changes from the other pr as well maybe you committed all changes to the same branch, do you want to try and fix it?

@Shivansh-22866

Copy link
Copy Markdown
Contributor Author

Sure, I'll work on it

@Shivansh-22866

Copy link
Copy Markdown
Contributor Author

Hi @jtemporal, kindly check if the changes are now only affecting the EN 26 card.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Migrate en 🇺🇸 card 26 to Mermaid

3 participants