MIL-116 Add memory showcase example#1861
Open
davidmarkgardiner wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new “memory showcase” example to demonstrate kagent long-term memory end-to-end (agent manifest + runnable A2A script + documentation), intended to help users understand and validate memory persistence across separate A2A contexts.
Changes:
- Adds a runnable demo script that sends two streamed A2A turns, verifies memory is stored, then verifies later retrieval.
- Adds Kubernetes resources (2
ModelConfigs + 1 memory-enabled declarativeAgent) to deploy the demo. - Adds documentation describing the memory persistence model, TTL/pruning behavior, and run/cleanup steps.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| examples/memory-showcase/run-demo.sh | Scripted A2A streaming demo that stores and later retrieves a fact via memory, with basic assertions. |
| examples/memory-showcase/README.md | Usage and conceptual documentation for memory persistence and how to run the demo. |
| examples/memory-showcase/memory-showcase.yaml | Manifest defining chat + embedding model configs and a memory-enabled declarative agent for the demo. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| Memory search is scoped by agent name and user ID. This demo sends a stable `X-User-ID` header so the second interaction can retrieve memory saved by the first interaction, even though the script uses a separate A2A context ID for the second turn. | ||
|
|
||
| `ttlDays` controls how long a memory remains valid before it is eligible for pruning. This example sets `ttlDays: 15`; omitting it or setting it to zero uses the server default of 15 days. Expired memories with low access counts are deleted by pruning. Expired memories with an access count of at least 10 are considered popular, have their TTL extended by 15 days, and have their access count reset. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs MIL-116
Validation
Live script reached the agent, but the local cluster has an invalid kagent-openai secret, so the model call returned OpenAI 401 and memory was not saved in this environment.