TEST: Cover absolute-size margin warning - #1377
Merged
Merged
Conversation
initial-d
force-pushed
the
test-absolute-size-margin-warning
branch
from
July 22, 2026 06:24
41f85c8 to
acd8c55
Compare
Owner
|
Ah, thanks for checking (and proving) that! |
Contributor
Author
|
Thanks for merging it, and thanks for the quick review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test for absolute-sized orders that are canceled because there is not enough margin.
This covers the behavior discussed in #1360. The implementation on current 'master' already emits a UserWarning for the absolute-size path; this test makes that behavior explicit and keeps it aligned with the existing relative-size warning path.
Validation:
Fixes #1360