Include final-bar open trades in results - #1382
Draft
bm1016bm-svg wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finalize_trades=FalseNaNand keep exposure and indicator columns validFixes #1342.
Testing
python -m backtesting.test(81 tests: 80 passed, 1 platform-specific skip)flake8 backtesting/_stats.py backtesting/backtesting.py backtesting/test/_test.pyLocal limitation
mypy backtestingcould not start because Windows Application Control blocked mypy's native DLL. GitHub Actions should provide the authoritative type-check result.AI assistance
OpenAI Codex assisted with issue discovery, implementation, tests, and validation. I reviewed the change and test results.