Preserve browser pool ID during updates - #113
Open
IlyaasK wants to merge 1 commit into
Open
Conversation
IlyaasK
force-pushed
the
fix/preserve-browser-pool-id-in-plan
branch
from
August 3, 2026 18:30
7ec5d9b to
53ea502
Compare
IlyaasK
force-pushed
the
fix/preserve-browser-pool-id-in-plan
branch
from
August 3, 2026 18:38
53ea502 to
eaa40bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Without
UseStateForUnknown, a normal browser pool update renders the stable ID and every dependent output as(known after apply), even though the resource is updated in place and retains its identity.Verification
go test ./internal/resources/browserpoolgo test -short -timeout=2m ./...go vet ./...git diff --checktimeout_secondskept the existing pool ID known in the planNote
Low Risk
Schema-only plan-modifier change with targeted tests; no runtime API or auth behavior changes.
Overview
Fixes Terraform plan noise on in-place
kernel_browser_poolupdates by applyingUseStateForUnknownto the computedidattribute so the stable pool ID is taken from state when the planned value is unknown, instead of showing(known after apply)for the ID and anything that references it.Adds
TestSchemaIDKeepsStateDuringUpdateto lock in that behavior (no replacement, planned ID stayspool-1from state). Renames the schema test helper torunStringPlanModifiersand reuses it for existingproject_idplan-modifier tests, with diagnostics failures surfaced in the helper.Reviewed by Cursor Bugbot for commit eaa40bf. Bugbot is set up for automated code reviews on this repo. Configure here.