Add browser pool core data source - #74
Open
IlyaasK wants to merge 3 commits into
Open
Conversation
IlyaasK
requested review from
Sayan- and
tnsardesai
and removed request for
Sayan- and
tnsardesai
July 11, 2026 10:16
IlyaasK
force-pushed
the
hypeship/browser-pool-resolved-refs
branch
from
July 13, 2026 13:35
c579964 to
546feff
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-core
branch
from
July 13, 2026 13:35
ad9b86d to
2a4d9ad
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-resolved-refs
branch
from
July 13, 2026 14:32
546feff to
c8beaf5
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-core
branch
2 times, most recently
from
July 13, 2026 15:39
825994b to
e0f20fd
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-core
branch
from
July 20, 2026 19:38
e0f20fd to
63f8898
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-resolved-refs
branch
from
July 20, 2026 19:38
8a17e4c to
8791796
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 63f8898. Configure here.
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-core
branch
2 times, most recently
from
July 21, 2026 18:10
feef7a2 to
d1f6e31
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-resolved-refs
branch
from
July 21, 2026 18:10
21051bf to
c1cb593
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-core
branch
from
July 21, 2026 19:51
d1f6e31 to
f5464c6
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-resolved-refs
branch
from
July 21, 2026 20:15
0418ff5 to
e569d69
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-core
branch
from
July 21, 2026 20:15
f5464c6 to
2da6ca9
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-resolved-refs
branch
2 times, most recently
from
July 27, 2026 18:17
3fa1515 to
c7c576d
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-core
branch
from
July 31, 2026 19:17
2da6ca9 to
e1a5354
Compare
IlyaasK
changed the base branch from
hypeship/browser-pool-resolved-refs
to
main
July 31, 2026 19:18
Expose exact browser pool lookup by ID or name with predictable project scoping. Keep the first slice limited to canonical identity, name, and durable size so runtime state cannot enter Terraform.
Lock selector, project scope, and computed attribute semantics after targeted mutation testing exposed missing schema assertions.
Keep schema mutation assertions concise so later browser-pool data source slices can verify their computed-only fields without duplicating type-specific checks.
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-core
branch
from
August 3, 2026 14:52
146156d to
1dbab8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
kernel_browser_pooldata sourceproject_id, then API-key bindingid,name,project_id, andsizeWhy
Existing browser pools can already be imported into the resource when Terraform should manage them. This data source covers the separate read-only case: reference an existing pool without taking ownership of its lifecycle.
The implementation performs one durable SDK GET and verifies that the returned ID or name matches the exact selector. API fields are validated before entering Terraform state.
Intentionally unsupported
Those durable read fields and acceptance coverage land in the following small PRs. No existing resource or data-source behavior changes.
Tests run
go test -short -timeout=2m ./...go test -race -count=1 -short -timeout=2m ./internal/datasources/browserpoolgo vet ./...gofmt -l cmd internalbash scripts/check-docs.shgit diff --check origin/main...HEADFocused tests cover schema and registration, Framework state writes, ID/name lookup, explicit/default/unscoped project selection, unnamed pools, API errors, nil or malformed responses, and selector mismatches.
Acceptance status
Not run in this PR. Live ID/name lookup and project scoping are added to the opt-in acceptance suite at the end of this stack.
Additional quality verification
@pr74core-state scenarioNote
Low Risk
Additive read-only data source with no changes to existing resources or data sources; risk is limited to new lookup behavior and API read validation.
Overview
Introduces
kernel_browser_poolas a read-only data source so Terraform can reference an existing browser pool without adopting the resource lifecycle (complementing import onkernel_browser_poolresource).Lookup uses exact
idorname(sharedResolveIDNameSelectorpattern),GetBrowserPool, and the same project scoping as other data sources (override → providerproject_id→ API key binding). Responses are validated and ID/name mismatches against the selector fail the read. State exposes only durable fields:id,name,project_id, andsize—no runtime pool/session attributes.Provider registration and generated docs are updated; unit tests cover schema, reads, project resolution, and error paths.
Reviewed by Cursor Bugbot for commit 1dbab8a. Bugbot is set up for automated code reviews on this repo. Configure here.