Fix https://github.com/kixe/FieldtypeSelectExtOption/issues/19#20
Open
tiefenb wants to merge 1 commit intokixe:masterfrom
Open
Fix https://github.com/kixe/FieldtypeSelectExtOption/issues/19#20tiefenb wants to merge 1 commit intokixe:masterfrom
tiefenb wants to merge 1 commit intokixe:masterfrom
Conversation
Owner
|
|
Author
|
I don't know - I upgraded from Version 2.1.3 to 2.2.0. The only modified code I'm using in our version is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced each('value') with Manual Loops:
For both $value and $_value, if they are instances of SelectExtOptionArray, we iterate over each item and collect the value property into $array1 or $array2.
Handled Different Value Types:
Properly checks if $value is a SelectExtOption, SelectExtOptionArray, array, or numeric, and processes each case to build $array1 and $int1 accordingly.
This approach ensures that we're working with plain PHP arrays, preventing the type error when using array_values().