fix: install podman 5.x from Ubuntu Plucky in CI & fix its runs-on value#3435
Open
gauron99 wants to merge 1 commit intoknative:mainfrom
Open
fix: install podman 5.x from Ubuntu Plucky in CI & fix its runs-on value#3435gauron99 wants to merge 1 commit intoknative:mainfrom
gauron99 wants to merge 1 commit intoknative:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
knative-prow
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
approved
gauron99
changed the title
gauron99
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3435 +/- ##
==========================================
+ Coverage 54.51% 55.24% +0.72%
==========================================
Files 179 179
Lines 20274 20274
==========================================
+ Hits 11052 11200 +148
+ Misses 8050 7902 -148
Partials 1172 1172
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gauron99
force-pushed
the
push-zrptzpusupqw
branch
4 times, most recently
from
fbc2ec9 to
b6c7697
Compare
gauron99
force-pushed
the
push-zrptzpusupqw
branch
from
b6c7697 to
250cc69
Compare
gauron99
changed the title
knative-prow
bot
removed
the
do-not-merge/work-in-progress
gauron99
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces 2 things:
why?
original failed podman test in CI
runs-on: ${{ matrix.os }}so that this runs as intended on both OSs