-
Notifications
You must be signed in to change notification settings - Fork 340
Fix panic on DeletedFinalStateUnknown in ConfigMap informer #3301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
|
Hi @anjalii-28. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This PR fixes the panic caused by DeletedFinalStateUnknown in the ConfigMap informer PTAL, thanks! |
|
/ok-to-test |
|
You'll need to sign the CLA - see this comment #3301 (comment) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3301 +/- ##
==========================================
+ Coverage 74.58% 74.62% +0.03%
==========================================
Files 188 188
Lines 8187 8192 +5
==========================================
+ Hits 6106 6113 +7
+ Misses 1841 1840 -1
+ Partials 240 239 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
acbb160 to
f95d534
Compare
|
/easycla |
|
/lgtm Thanks for the change - let me know when you sort out the EasyCLA |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anjalii-28, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
/easycla |
|
easy cla isn't satisfied - unsure if you need to sign older commits? Generally though I thought it was tied to the email in your github account |
|
I'm not really an EasyCLA expert so you'll want to open an issue here: https://github.com/linuxfoundation/easycla |
|
@anjalii-28 any luck with the CLA? |
e0d3659 to
cf07b65
Compare
Yes, easyCLA is now sorted, please review and approve the PR. |
Fixes #3220