Skip to content

Add script to update semconv version if OTel is updated - #3385

Open
dsimansk wants to merge 1 commit into
knative:mainfrom
dsimansk:pr/enable-otel-autoupdate
Open

Add script to update semconv version if OTel is updated#3385
dsimansk wants to merge 1 commit into
knative:mainfrom
dsimansk:pr/enable-otel-autoupdate

Conversation

@dsimansk

Copy link
Copy Markdown
Contributor

Changes

  • Add script to update semconv version if OTel is updated

Semconv version is used in the import path, after OTel version update there might be a mismatch between schemas. The script should detect the version and based on inline mapping or fetching correct version from OTel gomod file update the appropriate imports.

E.g.: #3381
https://github.com/knative/pkg/blob/main/observability/semconv/semconv.go#L21

/cc @dprotaso @gauron99

@knative-prow
knative-prow Bot requested review from dprotaso and gauron99 August 20, 2026 18:26
@knative-prow

knative-prow Bot commented Aug 20, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 20, 2026
@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.88%. Comparing base (d2a153a) to head (ca9caf5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3385      +/-   ##
==========================================
+ Coverage   74.85%   74.88%   +0.02%     
==========================================
  Files         189      189              
  Lines        8349     8349              
==========================================
+ Hits         6250     6252       +2     
+ Misses       1854     1853       -1     
+ Partials      245      244       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dsimansk
dsimansk force-pushed the pr/enable-otel-autoupdate branch from e82c9e0 to ca9caf5 Compare August 31, 2026 10:16
@knative-prow

knative-prow Bot commented Aug 31, 2026

Copy link
Copy Markdown

@dsimansk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
build-tests_pkg_main ca9caf5 link true /test build-tests

Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant