docs: use podman runtime in examples instead of fake#176
docs: use podman runtime in examples instead of fake#176feloy merged 1 commit intokortex-hub:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughUpdated user-facing documentation across Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
628-658:⚠️ Potential issue | 🟠 MajorRemaining
fakeruntime examples should be updated topodman.There are still user-facing examples showing
fakeruntime (Line 635, Line 651, Line 1575), which leaves the docs inconsistent with this PR objective.Suggested doc fix
-export KORTEX_CLI_DEFAULT_RUNTIME=fake +export KORTEX_CLI_DEFAULT_RUNTIME=podman ... -export KORTEX_CLI_DEFAULT_RUNTIME=fake +export KORTEX_CLI_DEFAULT_RUNTIME=podman ... -kortex-cli init -r fake -a claude -o json -v +kortex-cli init -r podman -a claude -o json -vAlso applies to: 1573-1576
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` around lines 628 - 658, Update the remaining example usages that still reference the "fake" runtime to use "podman" instead: replace occurrences of KORTEX_CLI_DEFAULT_RUNTIME=fake and example commands like `kortex-cli init ... --runtime fake` with `podman`, including the usage examples under the KORTEX_CLI_DEFAULT_RUNTIME section and the other example block around lines referenced (the examples showing `fake` at the end of the README); ensure both the environment variable example and the command-line override examples use `podman` so the docs are consistent with the PR objective.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 426: Remove the leading shell prompt characters from the inline command
snippets to satisfy markdownlint MD014: replace occurrences of "$ kortex-cli
init /path/to/project --runtime podman --agent claude -o json" and the other
similar lines (the snippets currently prefixed with "$" at the README) with the
bare commands (e.g., "kortex-cli init /path/to/project --runtime podman --agent
claude -o json"), and do the same for the other reported occurrences so each
fenced/indented code block contains only the command text without a "$" prompt.
---
Outside diff comments:
In `@README.md`:
- Around line 628-658: Update the remaining example usages that still reference
the "fake" runtime to use "podman" instead: replace occurrences of
KORTEX_CLI_DEFAULT_RUNTIME=fake and example commands like `kortex-cli init ...
--runtime fake` with `podman`, including the usage examples under the
KORTEX_CLI_DEFAULT_RUNTIME section and the other example block around lines
referenced (the examples showing `fake` at the end of the README); ensure both
the environment variable example and the command-line override examples use
`podman` so the docs are consistent with the PR objective.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cb019c33-509d-42a2-8334-5841da7671f3
📒 Files selected for processing (2)
README.mdpkg/cmd/init.go
Updates all user-facing documentation to demonstrate the podman runtime instead of the fake runtime, making examples more practical for actual usage. Fixes kortex-hub#175 Co-Authored-By: Claude Code (Claude Sonnet 4.5) <noreply@anthropic.com> Signed-off-by: Philippe Martin <phmartin@redhat.com>
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
1652-1655:⚠️ Potential issue | 🟡 MinorReplace the remaining
fakeruntime example to fully meet the PR objective.There is still one user-facing example using
-r fake, which conflicts with the podman-only documentation update objective.Suggested fix
**JSON output with short flags:** ```bash -kortex-cli init -r fake -a claude -o json -v +kortex-cli init -r podman -a claude -o json -v</details> <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against the current code and only fix it if needed.
In
@README.mdaround lines 1652 - 1655, Update the remaining example command
that uses the fake runtime by changing the runtime flag value in the user-facing
example string "kortex-cli init -r fake -a claude -o json -v" to use the podman
runtime; replace "kortex-cli init -r fake -a claude -o json -v" with "kortex-cli
init -r podman -a claude -o json -v" so the README no longer shows the
deprecated fake runtime.</details> </blockquote></details> </blockquote></details>🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed. Outside diff comments: In `@README.md`: - Around line 1652-1655: Update the remaining example command that uses the fake runtime by changing the runtime flag value in the user-facing example string "kortex-cli init -r fake -a claude -o json -v" to use the podman runtime; replace "kortex-cli init -r fake -a claude -o json -v" with "kortex-cli init -r podman -a claude -o json -v" so the README no longer shows the deprecated fake runtime.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID:
0502cca1-2764-4b00-abc9-460f3941694c📒 Files selected for processing (2)
README.mdpkg/cmd/init.go✅ Files skipped from review due to trivial changes (1)
- pkg/cmd/init.go
Updates all user-facing documentation to demonstrate the podman runtime instead of the fake runtime, making examples more practical for actual usage.
Fixes #175