feat(Workspace): show message dialog when error occupied

[gastoner]

Adds message dialog when error occupies when starting/stopping a workspace

Closes #1215

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0d2e9f39-55ea-431c-b109-feec964f1b21

📥 Commits

Reviewing files that changed from the base of the PR and between 1c59e7b and 0b8d031.

📒 Files selected for processing (6)

• packages/renderer/src/lib/agent-workspaces/AgentWorkspaceCard.spec.ts
• packages/renderer/src/lib/agent-workspaces/AgentWorkspaceCard.svelte
• packages/renderer/src/lib/agent-workspaces/AgentWorkspaceDetails.spec.ts
• packages/renderer/src/lib/agent-workspaces/AgentWorkspaceDetails.svelte
• packages/renderer/src/stores/agent-workspaces.svelte.spec.ts
• packages/renderer/src/stores/agent-workspaces.svelte.ts

---

📝 Walkthrough

Walkthrough

This change enhances error reporting for workspace start/stop operations. Previously, errors were silently logged via .catch(console.error). Now, the store functions rethrow errors after status cleanup, and UI components catch them to display user-facing error dialogs showing operation context and failure details.

Changes

Cohort / File(s)	Summary
Component Async Error Handling packages/renderer/src/lib/agent-workspaces/AgentWorkspaceCard.svelte, packages/renderer/src/lib/agent-workspaces/AgentWorkspaceDetails.svelte	Converted handleStartStop from fire-and-forget to async with try/catch. Now awaits workspace operations and shows error dialog via window.showMessageBox on failure, including action context ("starting"/"stopping") and workspace name.
Component Error Tests packages/renderer/src/lib/agent-workspaces/AgentWorkspaceCard.spec.ts, packages/renderer/src/lib/agent-workspaces/AgentWorkspaceDetails.spec.ts	Added 6 new test cases validating error dialog display when startAgentWorkspace and stopAgentWorkspace reject. Tests verify error message content, dialog type, and workspace status preservation after failure.
Store Error Propagation packages/renderer/src/stores/agent-workspaces.svelte.ts	Both startAgentWorkspace and stopAgentWorkspace now rethrow caught errors after updating status and logging, enabling callers to handle failures.
Store Error Rethrow Tests packages/renderer/src/stores/agent-workspaces.svelte.spec.ts	Updated 2 test cases to assert that failed operations reject by using await expect(...).rejects.toThrow(...) pattern.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• chore(workspace-manager): refactor worskspace store to use sveltemap for statuses #1151: Updates the agent-workspaces store with SvelteMap and status-set logic changes that overlap with this PR's store modifications.
• feat(workspace-manager): add start and stop functions in the backend #1137: Adds backend IPC handlers and preload-exposed startAgentWorkspace/stopAgentWorkspace APIs that this PR now invokes with proper error handling.
• feat: start stop button in workspace #1140: Directly related as it modifies the same start/stop workspace flows (store behavior, component handlers, and test coverage).

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding a message dialog to display errors when workspace start/stop operations fail, which aligns with the primary objective of the changeset.
Description check	✅ Passed	The description clearly states the purpose and references the linked issue #1215, which addresses error reporting during workspace operations.
Linked Issues check	✅ Passed	The PR successfully implements error reporting for workspace start failures [#1215] by adding try/catch blocks, error dialogs via window.showMessageBox, and comprehensive test coverage for both start and stop failure scenarios.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to implementing error reporting for workspace start/stop operations through error dialogs and tests, with no unrelated modifications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[bmahabirbu]

Looks good!

[jeffmaury]

Tested it on Windows but it did not report an error while the CLI does