Repository navigation
Conversation
BindHeaders indexed the first value of a header, query, or form entry. A nil or empty slice panicked. net/http Header.Get returns an empty string for that slice, and binding now does the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3169.
BindHeaders, and the query and form paths that sharebindData, read the first string in a value slice. A key whose slice is nil or empty panics withindex out of range [0] with length 0. A normal request line does not create that slice.Header.Set("X-Empty", "")stores[]string{""}and already binds. Assigning nil or an empty slice into the header map is what panics.net/httpHeader.Getreturns""for a missing key and for an empty slice. Binding now does the same. A struct field stays at its zero value.map[string]stringandmap[string]anystore"".[]string{""}is unchanged.go test -count=1 .passed. With the length checks disabled,TestBindHeadersEmptyValueSlicepanics atbind.gowithindex out of range [0] with length 0.