feat: implemented tokenizer plugins in rust #5583
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuhitoT
commented
Dec 26, 2025
Comment on lines
+48
to
+55
| fn create_stream<'a>(&'a mut self, text: &'a str) -> BoxTokenStream<'a> { | ||
| // Note: This is not the most efficient approach for repeated tokenization, | ||
| // but it ensures thread safety and simplifies lifetime management. | ||
| // For production use, consider caching the factory/tokenizer. | ||
| let stream = PluginTokenStreamAdapter::new(Arc::clone(&self.library), &self.config, text); | ||
| BoxTokenStream::new(stream) | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Creating the factory is expensive because it loads a tokenizer plugin (~*MB).
Should we cache the factory only, or cache both the factory and the tokenizer?
KazuhitoT
commented
Dec 26, 2025
Comment on lines
+313
to
+317
| // Plugin tokenizer is handled separately as it returns LanceTokenizer directly | ||
| if self.base_tokenizer == "plugin" { | ||
| return self.build_plugin_tokenizer(); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Since build_plugin_tokenizer() returns a LanceTokenizer, I added an early return instead of adding a new match condition in build_base_tokenizer(), which returns a TextAnalyzerBuilder.
Should I unify this branching logic?
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #3222
Key changes are as bellows:
include/lance_tokenizer_plugin.h: add C API for the tokenizer pluginprotos/index_old.proto: add two fields to restore the plugin tokenizer configurationrust/lance-index/src/scalar/inverted/tokenizer.rsandrust/lance-index/src/scalar/inverted/plugin/*: implement tokenizer loadingrust/lance-index/examples/: add an example usageDuring the PR creation process, I had two questions and left comments in the PR.