fix: allow merge insert write parameters - #7969
Open
zlepper wants to merge 1 commit into
Open
Conversation
Allow MergeInsertBuilder callers to configure the WriteParams used when merge operations create fragments. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6426.
Merge-insert currently creates data fragments with
WriteParams::default(), so callers cannot configure blob handling or any other write behavior.Add
MergeInsertBuilder::with_write_params, which accepts a callback over the current parameters and forwards the resulting configuration through both full-schema merge fragment-write paths.The regression test verifies that merge-insert forwards
allow_external_blob_outside_basesfor an external Blob V2 URI.Do note: I'm not entirely sure about the target branch here, but copilot figured this was the correct target to get these changes in a minor release :)