Skip to content

fix: allow merge insert write parameters - #7969

Open
zlepper wants to merge 1 commit into
lance-format:release/v8.0from
zlepper:feature/merge-insert-write-params-v8
Open

fix: allow merge insert write parameters#7969
zlepper wants to merge 1 commit into
lance-format:release/v8.0from
zlepper:feature/merge-insert-write-params-v8

Conversation

@zlepper

@zlepper zlepper commented Jul 24, 2026

Copy link
Copy Markdown

Fixes #6426.

Merge-insert currently creates data fragments with WriteParams::default(), so callers cannot configure blob handling or any other write behavior.

Add MergeInsertBuilder::with_write_params, which accepts a callback over the current parameters and forwards the resulting configuration through both full-schema merge fragment-write paths.

The regression test verifies that merge-insert forwards allow_external_blob_outside_bases for an external Blob V2 URI.

Do note: I'm not entirely sure about the target branch here, but copilot figured this was the correct target to get these changes in a minor release :)

Allow MergeInsertBuilder callers to configure the WriteParams used when merge operations create fragments.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: af3b598c-bffa-4add-9536-a8ab44f7990d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the bug Something isn't working label Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant