fix(datafusion): preserve boolean expression literal types - #9322
Open
lance-gatefixer[bot] wants to merge 2 commits into
Open
lance-gatefixer[bot] wants to merge 2 commits into
lance-gatefixer[bot] wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The prior non-blocking coercion risk is fixed in e6c385771: supported constant shifts and string concatenation now retain the column type, with execution regression tests covering both. The original Boolean-expression fix remains intact and no material residual risk remains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The filter resolver recursively coerced every literal inside any right-hand binary expression to the type of the outer left column. When the outer column was Boolean, literals belonging to nested numeric comparisons were incorrectly converted to Boolean before DataFusion planned the expression.
Validation
cargo fmt --allcargo test -p lance-datafusion(188 tests and doctests passed)cargo clippy --all --tests --benches -- -D warningsFixes #9319